From: Andrew Morton ERROR: no space after that open parenthesis '(' #35: FILE: drivers/block/loop.c:976: + if ( (lo->lo_flags & LO_FLAGS_AUTOCLEAR) != total: 1 errors, 0 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Bernardo Innocenti Cc: David Woodhouse Signed-off-by: Andrew Morton --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/block/loop.c~allow-auto-destruction-of-loop-devices-checkpatch-fixes drivers/block/loop.c --- a/drivers/block/loop.c~allow-auto-destruction-of-loop-devices-checkpatch-fixes +++ a/drivers/block/loop.c @@ -973,7 +973,7 @@ loop_set_status(struct loop_device *lo, lo->transfer = xfer->transfer; lo->ioctl = xfer->ioctl; - if ( (lo->lo_flags & LO_FLAGS_AUTOCLEAR) != + if ((lo->lo_flags & LO_FLAGS_AUTOCLEAR) != (info->lo_flags & LO_FLAGS_AUTOCLEAR)) lo->lo_flags ^= LO_FLAGS_AUTOCLEAR; _