From david-b@pacbell.net Thu Dec 6 13:29:54 2007 From: Benjamin Herrenschmidt Date: Thu, 6 Dec 2007 13:29:46 -0800 Subject: usb: Remove OHCI useless masking/unmasking of WDH interrupt To: Greg KH Cc: Benjamin Herrenschmidt , linux-usb-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org Message-ID: <200712061329.47591.david-b@pacbell.net> Content-Disposition: inline From: Benjamin Herrenschmidt Subject: [PATCH 2/2] usb: Remove OHCI useless masking/unmasking of WDH interrupt The OHCI driver's IRQ handler, while processing a WDH interrupt, masks and unmasks it. I believe this is both broken (the write may still be posted during the donelist processing it's trying to safeguard) and useless as this IRQ may not be reissued until it's acked (unless this legacy code is an uncommented workaround for some chip erratum). Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Brownell Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ohci-hcd.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -810,13 +810,9 @@ static irqreturn_t ohci_irq (struct usb_ } if (ints & OHCI_INTR_WDH) { - if (HC_IS_RUNNING(hcd->state)) - ohci_writel (ohci, OHCI_INTR_WDH, ®s->intrdisable); spin_lock (&ohci->lock); dl_done_list (ohci); spin_unlock (&ohci->lock); - if (HC_IS_RUNNING(hcd->state)) - ohci_writel (ohci, OHCI_INTR_WDH, ®s->intrenable); } if (quirk_zfmicro(ohci) && (ints & OHCI_INTR_SF)) {