From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #31: FILE: fs/ext2/ext2.h:127: +extern struct inode *ext2_iget (struct super_block *, unsigned long); WARNING: no space between function name and open parenthesis '(' #43: FILE: fs/ext2/inode.c:1188: +struct inode *ext2_iget (struct super_block *sb, unsigned long ino) ERROR: "foo * bar" should be "foo *bar" #50: FILE: fs/ext2/inode.c:1192: + struct ext2_inode * raw_inode; total: 1 errors, 2 warnings, 161 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Theodore Ts'o" Cc: Cc: David Howells Signed-off-by: Andrew Morton --- fs/ext2/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/ext2/inode.c~iget-stop-ext2-from-using-iget-and-read_inode-try-checkpatch-fixes fs/ext2/inode.c --- a/fs/ext2/inode.c~iget-stop-ext2-from-using-iget-and-read_inode-try-checkpatch-fixes +++ a/fs/ext2/inode.c @@ -1186,7 +1186,7 @@ struct inode *ext2_iget (struct super_bl { struct ext2_inode_info *ei; struct buffer_head * bh; - struct ext2_inode * raw_inode; + struct ext2_inode *raw_inode; struct inode *inode; long ret = -EIO; int n; _