From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #30: FILE: fs/ufs/inode.c:717: +struct inode *ufs_iget (struct super_block *sb, unsigned long ino) ERROR: "foo * bar" should be "foo *bar" #36: FILE: fs/ufs/inode.c:720: + struct ufs_sb_private_info * uspi = UFS_SB(sb)->s_uspi; total: 1 errors, 1 warnings, 118 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: David Howells Cc: Evgeniy Dushistov Signed-off-by: Andrew Morton --- fs/ufs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/ufs/inode.c~iget-stop-ufs-from-using-iget-and-read_inode-try-checkpatch-fixes fs/ufs/inode.c --- a/fs/ufs/inode.c~iget-stop-ufs-from-using-iget-and-read_inode-try-checkpatch-fixes +++ a/fs/ufs/inode.c @@ -714,10 +714,10 @@ static int ufs2_read_inode(struct inode return 0; } -struct inode *ufs_iget (struct super_block *sb, unsigned long ino) +struct inode *ufs_iget(struct super_block *sb, unsigned long ino) { struct ufs_inode_info *ufsi; - struct ufs_sb_private_info * uspi = UFS_SB(sb)->s_uspi; + struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi; struct buffer_head * bh; struct inode *inode; int err; _