From: Andrew Morton ERROR: "foo * bar" should be "foo *bar" #244: FILE: lib/semaphore-sleepers.c:56: +void __sched __down(struct semaphore * sem) ERROR: "foo * bar" should be "foo *bar" #253: FILE: lib/semaphore-sleepers.c:93: +int __sched __down_interruptible(struct semaphore * sem) ERROR: "foo * bar" should be "foo *bar" #262: FILE: lib/semaphore-sleepers.c:156: +int __down_trylock(struct semaphore * sem) total: 3 errors, 0 warnings, 222 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Harvey Harrison Signed-off-by: Andrew Morton --- lib/semaphore-sleepers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN lib/semaphore-sleepers.c~lib-remove-fastcall-from-lib-checkpatch-fixes lib/semaphore-sleepers.c --- a/lib/semaphore-sleepers.c~lib-remove-fastcall-from-lib-checkpatch-fixes +++ a/lib/semaphore-sleepers.c @@ -53,7 +53,7 @@ void __up(struct semaphore *sem) wake_up(&sem->wait); } -void __sched __down(struct semaphore * sem) +void __sched __down(struct semaphore *sem) { struct task_struct *tsk = current; DECLARE_WAITQUEUE(wait, tsk); @@ -90,7 +90,7 @@ void __sched __down(struct semaphore * s tsk->state = TASK_RUNNING; } -int __sched __down_interruptible(struct semaphore * sem) +int __sched __down_interruptible(struct semaphore *sem) { int retval = 0; struct task_struct *tsk = current; @@ -153,7 +153,7 @@ int __sched __down_interruptible(struct * single "cmpxchg" without failure cases, * but then it wouldn't work on a 386. */ -int __down_trylock(struct semaphore * sem) +int __down_trylock(struct semaphore *sem) { int sleepers; unsigned long flags; _