From: Andrew Morton WARNING: line over 80 characters #36: FILE: drivers/ata/pata_bf54x.c:1512: + while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) { ERROR: need spaces around that '>' (ctx:VxV) #36: FILE: drivers/ata/pata_bf54x.c:1512: + while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) { ^ total: 1 errors, 1 warnings, 19 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jeff Garzik Cc: Sonic Zhang Cc: Tejun Heo Cc: sonic zhang Signed-off-by: Andrew Morton --- drivers/ata/pata_bf54x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drivers/ata/pata_bf54x.c~libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes drivers/ata/pata_bf54x.c --- a/drivers/ata/pata_bf54x.c~libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes +++ a/drivers/ata/pata_bf54x.c @@ -1514,7 +1514,8 @@ static int __devinit bfin_atapi_probe(st if (res == NULL) return -EINVAL; - while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) { + while (bfin_port_info[board_idx].udma_mask > 0 && + udma_fsclk[udma_mode] > fsclk) { udma_mode--; bfin_port_info[board_idx].udma_mask >>= 1; } _