From: Andrew Morton ERROR: else should follow close brace '}' #190: FILE: kernel/exit.c:1636: + } + else if (upid == 0) { ERROR: else should follow close brace '}' #194: FILE: kernel/exit.c:1640: + } + else /* upid > 0 */ { ERROR: need spaces around that '=' (ctx:VxW) #195: FILE: kernel/exit.c:1641: + type= PIDTYPE_PID; ^ total: 3 errors, 0 warnings, 160 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Eric W. Biederman Signed-off-by: Andrew Morton --- kernel/exit.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff -puN kernel/exit.c~pid-sys_wait-fixes-v2-checkpatch-fixes kernel/exit.c --- a/kernel/exit.c~pid-sys_wait-fixes-v2-checkpatch-fixes +++ a/kernel/exit.c @@ -1632,13 +1632,11 @@ asmlinkage long sys_wait4(pid_t upid, in else if (upid < 0) { type = PIDTYPE_PGID; pid = find_get_pid(-upid); - } - else if (upid == 0) { + } else if (upid == 0) { type = PIDTYPE_PGID; pid = get_pid(task_pgrp(current)); - } - else /* upid > 0 */ { - type= PIDTYPE_PID; + } else /* upid > 0 */ { + type = PIDTYPE_PID; pid = find_get_pid(upid); } _