From: Andrew Morton ERROR: need a space before the open parenthesis '(' #97: FILE: fs/hfs/btree.c:84: + switch(id) { total: 1 errors, 0 warnings, 93 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Eric Sandeen Cc: Roman Zippel Signed-off-by: Andrew Morton --- fs/hfs/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/hfs/btree.c~address-hfs-on-disk-corruption-robustness-review-comments-checkpatch-fixes fs/hfs/btree.c --- a/fs/hfs/btree.c~address-hfs-on-disk-corruption-robustness-review-comments-checkpatch-fixes +++ a/fs/hfs/btree.c @@ -81,7 +81,7 @@ struct hfs_btree *hfs_btree_open(struct goto fail_page; if (!tree->node_count) goto fail_page; - switch(id) { + switch (id) { case HFS_EXT_CNID: if (tree->max_key_len != HFS_MAX_EXT_KEYLEN) { printk(KERN_ERR "hfs: invalid extent max_key_len %d\n", _