From: Andrew Morton WARNING: line over 80 characters #56: FILE: drivers/pnp/pnpacpi/rsparser.c:427: + struct acpi_resource_extended_irq *p) WARNING: line over 80 characters #78: FILE: drivers/pnp/pnpacpi/rsparser.c:466: + struct acpi_resource_fixed_io *io) WARNING: line over 80 characters #111: FILE: drivers/pnp/pnpacpi/rsparser.c:525: + struct acpi_resource_fixed_memory32 *p) ERROR: "foo * bar" should be "foo *bar" #144: FILE: drivers/pnp/pnpacpi/rsparser.c:692: + struct pnp_dev * dev) WARNING: line over 80 characters #243: FILE: drivers/pnp/pnpbios/rsparser.c:374: +static __init unsigned char *pnpbios_parse_resource_option_data(unsigned char *p, WARNING: line over 80 characters #244: FILE: drivers/pnp/pnpbios/rsparser.c:375: + unsigned char *end, WARNING: line over 80 characters #245: FILE: drivers/pnp/pnpbios/rsparser.c:376: + struct pnp_dev *dev) WARNING: line over 80 characters #254: FILE: drivers/pnp/pnpbios/rsparser.c:784: +int __init pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node *node) total: 1 errors, 7 warnings, 204 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Bjorn Helgaas Cc: Rene Herman Cc: Thomas Renninger Signed-off-by: Andrew Morton --- drivers/pnp/pnpacpi/rsparser.c | 8 ++++---- drivers/pnp/pnpbios/rsparser.c | 9 +++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff -puN drivers/pnp/pnpacpi/rsparser.c~declare-pnp-option-parsing-functions-as-__init-checkpatch-fixes drivers/pnp/pnpacpi/rsparser.c --- a/drivers/pnp/pnpacpi/rsparser.c~declare-pnp-option-parsing-functions-as-__init-checkpatch-fixes +++ a/drivers/pnp/pnpacpi/rsparser.c @@ -433,7 +433,7 @@ static __init void pnpacpi_parse_irq_opt } static __init void pnpacpi_parse_ext_irq_option(struct pnp_option *option, - struct acpi_resource_extended_irq *p) + struct acpi_resource_extended_irq *p) { int i; struct pnp_irq *irq; @@ -472,7 +472,7 @@ static __init void pnpacpi_parse_port_op } static __init void pnpacpi_parse_fixed_port_option(struct pnp_option *option, - struct acpi_resource_fixed_io *io) + struct acpi_resource_fixed_io *io) { struct pnp_port *port; @@ -531,7 +531,7 @@ static __init void pnpacpi_parse_mem32_o } static __init void pnpacpi_parse_fixed_mem32_option(struct pnp_option *option, - struct acpi_resource_fixed_memory32 *p) + struct acpi_resource_fixed_memory32 *p) { struct pnp_mem *mem; @@ -698,7 +698,7 @@ static __init acpi_status pnpacpi_option } acpi_status __init pnpacpi_parse_resource_option_data(acpi_handle handle, - struct pnp_dev * dev) + struct pnp_dev *dev) { acpi_status status; struct acpipnp_parse_option_s parse_data; diff -puN drivers/pnp/pnpbios/rsparser.c~declare-pnp-option-parsing-functions-as-__init-checkpatch-fixes drivers/pnp/pnpbios/rsparser.c --- a/drivers/pnp/pnpbios/rsparser.c~declare-pnp-option-parsing-functions-as-__init-checkpatch-fixes +++ a/drivers/pnp/pnpbios/rsparser.c @@ -371,9 +371,9 @@ static __init void pnpbios_parse_fixed_p pnp_register_port_resource(option, port); } -static __init unsigned char *pnpbios_parse_resource_option_data(unsigned char *p, - unsigned char *end, - struct pnp_dev *dev) +static __init unsigned char * +pnpbios_parse_resource_option_data(unsigned char *p, unsigned char *end, + struct pnp_dev *dev) { unsigned int len, tag; int priority = 0; @@ -781,7 +781,8 @@ len_err: * Core Parsing Functions */ -int __init pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node *node) +int __init pnpbios_parse_data_stream(struct pnp_dev *dev, + struct pnp_bios_node *node) { unsigned char *p = (char *)node->data; unsigned char *end = (char *)(node->data + node->size); _