From: Andrew Morton ERROR: "foo * bar" should be "foo *bar" #188: FILE: fs/namei.c:827: +static int __link_path_walk(const char * name, struct nameidata *nd) ERROR: "foo * bar" should be "foo *bar" #206: FILE: fs/namei.c:1043: +static int path_walk(const char * name, struct nameidata *nd) ERROR: "foo * bar" should be "foo *bar" #263: FILE: fs/open.c:1017: +void fd_install(unsigned int fd, struct file * file) total: 3 errors, 0 warnings, 209 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Harvey Harrison Signed-off-by: Andrew Morton --- fs/namei.c | 4 ++-- fs/open.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff -puN fs/namei.c~fs-remove-fastcall-it-is-always-empty-checkpatch-fixes fs/namei.c --- a/fs/namei.c~fs-remove-fastcall-it-is-always-empty-checkpatch-fixes +++ a/fs/namei.c @@ -833,7 +833,7 @@ fail: * Returns 0 and nd will have valid dentry and mnt on success. * Returns error and drops reference to input namei data on failure. */ -static int __link_path_walk(const char * name, struct nameidata *nd) +static int __link_path_walk(const char *name, struct nameidata *nd) { struct path next; struct inode *inode; @@ -1051,7 +1051,7 @@ static int link_path_walk(const char *na return result; } -static int path_walk(const char * name, struct nameidata *nd) +static int path_walk(const char *name, struct nameidata *nd) { current->total_link_count = 0; return link_path_walk(name, nd); diff -puN fs/open.c~fs-remove-fastcall-it-is-always-empty-checkpatch-fixes fs/open.c --- a/fs/open.c~fs-remove-fastcall-it-is-always-empty-checkpatch-fixes +++ a/fs/open.c @@ -1050,7 +1050,7 @@ EXPORT_SYMBOL(put_unused_fd); * will follow. */ -void fd_install(unsigned int fd, struct file * file) +void fd_install(unsigned int fd, struct file *file) { struct files_struct *files = current->files; struct fdtable *fdt; _