From: Andrew Morton ERROR: use tabs not spaces #54: FILE: fs/qnx4/inode.c:398: + ^Iroot = qnx4_iget(s, QNX4_ROOT_INO * QNX4_INODES_PER_BLOCK);$ ERROR: use tabs not spaces #55: FILE: fs/qnx4/inode.c:399: + ^Iif (IS_ERR(root)) {$ WARNING: line over 80 characters #103: FILE: fs/qnx4/inode.c:485: + printk("qnx4: bad inode number on dev %s: %lu is out of range\n", WARNING: printk() should include KERN_ facility level #103: FILE: fs/qnx4/inode.c:485: + printk("qnx4: bad inode number on dev %s: %lu is out of range\n", WARNING: printk() should include KERN_ facility level #127: FILE: fs/qnx4/inode.c:528: + printk("qnx4: bad inode %lu on dev %s\n",ino,sb->s_id); ERROR: need space after that ',' (ctx:VxV) #127: FILE: fs/qnx4/inode.c:528: + printk("qnx4: bad inode %lu on dev %s\n",ino,sb->s_id); ^ ERROR: need space after that ',' (ctx:VxV) #127: FILE: fs/qnx4/inode.c:528: + printk("qnx4: bad inode %lu on dev %s\n",ino,sb->s_id); ^ total: 4 errors, 3 warnings, 129 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Anders Larsen Cc: David Howells Signed-off-by: Andrew Morton --- fs/qnx4/inode.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff -puN fs/qnx4/inode.c~iget-stop-qnx4-from-using-iget-and-read_inode-try-checkpatch-fixes fs/qnx4/inode.c --- a/fs/qnx4/inode.c~iget-stop-qnx4-from-using-iget-and-read_inode-try-checkpatch-fixes +++ a/fs/qnx4/inode.c @@ -395,8 +395,8 @@ static int qnx4_fill_super(struct super_ } /* does root not have inode number QNX4_ROOT_INO ?? */ - root = qnx4_iget(s, QNX4_ROOT_INO * QNX4_INODES_PER_BLOCK); - if (IS_ERR(root)) { + root = qnx4_iget(s, QNX4_ROOT_INO * QNX4_INODES_PER_BLOCK); + if (IS_ERR(root)) { printk("qnx4: get inode failed\n"); ret = PTR_ERR(root); goto out; @@ -482,7 +482,8 @@ struct inode *qnx4_iget(struct super_blo QNX4DEBUG(("Reading inode : [%d]\n", ino)); if (!ino) { - printk("qnx4: bad inode number on dev %s: %lu is out of range\n", + printk(KERN_ERR "qnx4: bad inode number on dev %s: %lu is " + "out of range\n", sb->s_id, ino); iget_failed(inode); return ERR_PTR(-EIO); @@ -525,7 +526,8 @@ struct inode *qnx4_iget(struct super_blo inode->i_mapping->a_ops = &qnx4_aops; qnx4_i(inode)->mmu_private = inode->i_size; } else { - printk("qnx4: bad inode %lu on dev %s\n",ino,sb->s_id); + printk(KERN_ERR "qnx4: bad inode %lu on dev %s\n", + ino, sb->s_id); iget_failed(inode); brelse(bh); return ERR_PTR(-EIO); _