From: Andrew Morton ERROR: use tabs not spaces #44: FILE: drivers/char/agp/intel-agp.c:41: + agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965GME_HB || \$ ERROR: use tabs not spaces #45: FILE: drivers/char/agp/intel-agp.c:42: + agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_IGD_HB)$ total: 2 errors, 0 warnings, 85 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Dave Airlie Cc: Zhenyu Wang Signed-off-by: Andrew Morton --- drivers/char/agp/intel-agp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/char/agp/intel-agp.c~intel_agp-add-new-chipset-ids-checkpatch-fixes drivers/char/agp/intel-agp.c --- a/drivers/char/agp/intel-agp.c~intel_agp-add-new-chipset-ids-checkpatch-fixes +++ a/drivers/char/agp/intel-agp.c @@ -38,8 +38,8 @@ agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965Q_HB || \ agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965G_HB || \ agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965GM_HB || \ - agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965GME_HB || \ - agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_IGD_HB) + agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_82965GME_HB || \ + agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_IGD_HB) #define IS_G33 (agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_G33_HB || \ agp_bridge->dev->device == PCI_DEVICE_ID_INTEL_Q35_HB || \ _