From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #21: FILE: drivers/char/lp.c:315: + if (mutex_lock_interruptible (&lp_table[minor].port_mutex)) WARNING: no space between function name and open parenthesis '(' #30: FILE: drivers/char/lp.c:402: + mutex_unlock (&lp_table[minor].port_mutex); WARNING: no space between function name and open parenthesis '(' #39: FILE: drivers/char/lp.c:424: + if (mutex_lock_interruptible (&lp_table[minor].port_mutex)) WARNING: no space between function name and open parenthesis '(' #48: FILE: drivers/char/lp.c:482: + mutex_unlock (&lp_table[minor].port_mutex); WARNING: no space between function name and open parenthesis '(' #57: FILE: drivers/char/lp.c:891: + mutex_init (&lp_table[i].port_mutex); total: 0 errors, 5 warnings, 56 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Matthias Kaehlcke Signed-off-by: Andrew Morton --- drivers/char/lp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/char/lp.c~parallel-port-convert-port_mutex-to-the-mutex-api-checkpatch-fixes drivers/char/lp.c --- a/drivers/char/lp.c~parallel-port-convert-port_mutex-to-the-mutex-api-checkpatch-fixes +++ a/drivers/char/lp.c @@ -312,7 +312,7 @@ static ssize_t lp_write(struct file * fi if (copy_size > LP_BUFFER_SIZE) copy_size = LP_BUFFER_SIZE; - if (mutex_lock_interruptible (&lp_table[minor].port_mutex)) + if (mutex_lock_interruptible(&lp_table[minor].port_mutex)) return -EINTR; if (copy_from_user (kbuf, buf, copy_size)) { @@ -399,7 +399,7 @@ static ssize_t lp_write(struct file * fi lp_release_parport (&lp_table[minor]); } out_unlock: - mutex_unlock (&lp_table[minor].port_mutex); + mutex_unlock(&lp_table[minor].port_mutex); return retv; } @@ -421,7 +421,7 @@ static ssize_t lp_read(struct file * fil if (count > LP_BUFFER_SIZE) count = LP_BUFFER_SIZE; - if (mutex_lock_interruptible (&lp_table[minor].port_mutex)) + if (mutex_lock_interruptible(&lp_table[minor].port_mutex)) return -EINTR; lp_claim_parport_or_block (&lp_table[minor]); @@ -479,7 +479,7 @@ static ssize_t lp_read(struct file * fil if (retval > 0 && copy_to_user (buf, kbuf, retval)) retval = -EFAULT; - mutex_unlock (&lp_table[minor].port_mutex); + mutex_unlock(&lp_table[minor].port_mutex); return retval; } @@ -888,7 +888,7 @@ static int __init lp_init (void) lp_table[i].last_error = 0; init_waitqueue_head (&lp_table[i].waitq); init_waitqueue_head (&lp_table[i].dataq); - mutex_init (&lp_table[i].port_mutex); + mutex_init(&lp_table[i].port_mutex); lp_table[i].timeout = 10 * HZ; } _