From: Andrew Morton ERROR: need space after that ',' (ctx:VxV) #87: FILE: fs/proc/generic.c:608: + ent = __proc_create(&parent,name, ^ ERROR: need space after that ',' (ctx:VxV) #105: FILE: fs/proc/generic.c:667: + ent = __proc_create(&parent,name,mode,nlink); ^ ERROR: need space after that ',' (ctx:VxV) #105: FILE: fs/proc/generic.c:667: + ent = __proc_create(&parent,name,mode,nlink); ^ ERROR: need space after that ',' (ctx:VxV) #105: FILE: fs/proc/generic.c:667: + ent = __proc_create(&parent,name,mode,nlink); ^ WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #172: FILE: fs/proc/root.c:235: +EXPORT_SYMBOL(proc_create); WARNING: line over 80 characters #183: FILE: include/linux/proc_fs.h:129: +struct proc_dir_entry *proc_create(const char *name, mode_t mode, struct proc_dir_entry *parent, const struct file_operations *proc_fops); WARNING: line over 80 characters #192: FILE: include/linux/proc_fs.h:222: +static inline struct proc_dir_entry *proc_create(const char *name, mode_t mode, struct proc_dir_entry *parent, const struct file_operations *proc_fops) total: 4 errors, 3 warnings, 108 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Eric W. Biederman" Cc: Alexey Dobriyan Cc: Oleg Nesterov Signed-off-by: Andrew Morton --- fs/proc/generic.c | 4 ++-- include/linux/proc_fs.h | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff -puN fs/proc/generic.c~proc-fix-openless-usage-due-to-proc_fops-flip-checkpatch-fixes fs/proc/generic.c --- a/fs/proc/generic.c~proc-fix-openless-usage-due-to-proc_fops-flip-checkpatch-fixes +++ a/fs/proc/generic.c @@ -605,7 +605,7 @@ struct proc_dir_entry *proc_symlink(cons { struct proc_dir_entry *ent; - ent = __proc_create(&parent,name, + ent = __proc_create(&parent, name, (S_IFLNK | S_IRUGO | S_IWUGO | S_IXUGO),1); if (ent) { @@ -664,7 +664,7 @@ struct proc_dir_entry *create_proc_entry nlink = 1; } - ent = __proc_create(&parent,name,mode,nlink); + ent = __proc_create(&parent, name, mode, nlink); if (ent) { if (proc_register(parent, ent) < 0) { kfree(ent); diff -puN include/linux/proc_fs.h~proc-fix-openless-usage-due-to-proc_fops-flip-checkpatch-fixes include/linux/proc_fs.h --- a/include/linux/proc_fs.h~proc-fix-openless-usage-due-to-proc_fops-flip-checkpatch-fixes +++ a/include/linux/proc_fs.h @@ -126,7 +126,9 @@ void de_put(struct proc_dir_entry *de); extern struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, struct proc_dir_entry *parent); -struct proc_dir_entry *proc_create(const char *name, mode_t mode, struct proc_dir_entry *parent, const struct file_operations *proc_fops); +struct proc_dir_entry *proc_create(const char *name, mode_t mode, + struct proc_dir_entry *parent, + const struct file_operations *proc_fops); extern void remove_proc_entry(const char *name, struct proc_dir_entry *parent); extern struct vfsmount *proc_mnt; @@ -221,7 +223,9 @@ static inline void proc_flush_task(struc static inline struct proc_dir_entry *create_proc_entry(const char *name, mode_t mode, struct proc_dir_entry *parent) { return NULL; } -static inline struct proc_dir_entry *proc_create(const char *name, mode_t mode, struct proc_dir_entry *parent, const struct file_operations *proc_fops) +static inline struct proc_dir_entry *proc_create(const char *name, + mode_t mode, struct proc_dir_entry *parent, + const struct file_operations *proc_fops) { return NULL; } _