From: Andrew Morton argh. ERROR: need spaces around that '=' (ctx:VxV) #58: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:131: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ ^ ERROR: no spaces around that '->' (ctx:VxW) #58: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:131: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ ^ ERROR: no space before that close parenthesis ')' #58: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:131: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ WARNING: no space between function name and open parenthesis '(' #59: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:132: + return asd_read_##ord (asd_ha, (unsigned long) map_offs); \ ERROR: need spaces around that '=' (ctx:VxV) #67: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:140: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ ^ ERROR: no spaces around that '->' (ctx:VxW) #67: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:140: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ ^ ERROR: no space before that close parenthesis ')' #67: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:140: + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ WARNING: no space between function name and open parenthesis '(' #68: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:141: + asd_write_##ord (asd_ha, (unsigned long)map_offs, val); \ total: 6 errors, 2 warnings, 38 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Darrick J. Wong" Cc: Adrian Bunk Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/aic94xx/aic94xx_reg.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/scsi/aic94xx/aic94xx_reg.c~scsi-aic94xx-cleanups-checkpatch-fixes-checkpatch-fixes drivers/scsi/aic94xx/aic94xx_reg.c --- a/drivers/scsi/aic94xx/aic94xx_reg.c~scsi-aic94xx-cleanups-checkpatch-fixes-checkpatch-fixes +++ a/drivers/scsi/aic94xx/aic94xx_reg.c @@ -128,8 +128,8 @@ static type asd_read_##ww##_##ord(struct u32 reg) \ { \ struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ - u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ - return asd_read_##ord (asd_ha, (unsigned long) map_offs); \ + u32 map_offs = (reg - io_handle->ww##_base) + asd_mem_offs_##ww();\ + return asd_read_##ord(asd_ha, (unsigned long)map_offs); \ } #define ASD_WRITE_SW(ww, type, ord) \ @@ -137,8 +137,8 @@ static void asd_write_##ww##_##ord(struc u32 reg, type val) \ { \ struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ - u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ - asd_write_##ord (asd_ha, (unsigned long)map_offs, val); \ + u32 map_offs = (reg - io_handle->ww##_base) + asd_mem_offs_##ww();\ + asd_write_##ord(asd_ha, (unsigned long)map_offs, val); \ } ASD_READ_SW(swa, u8, byte); _