From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #357: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:127: +static type asd_read_##ww##_##ord (struct asd_ha_struct *asd_ha, \ WARNING: no space between function name and open parenthesis '(' #368: FILE: drivers/scsi/aic94xx/aic94xx_reg.c:136: +static void asd_write_##ww##_##ord (struct asd_ha_struct *asd_ha, \ total: 0 errors, 2 warnings, 531 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches (fix other stuff too. tabs!) Cc: "Darrick J. Wong" Cc: Adrian Bunk Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/aic94xx/aic94xx_reg.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff -puN drivers/scsi/aic94xx/aic94xx_reg.c~scsi-aic94xx-cleanups-checkpatch-fixes drivers/scsi/aic94xx/aic94xx_reg.c --- a/drivers/scsi/aic94xx/aic94xx_reg.c~scsi-aic94xx-cleanups-checkpatch-fixes +++ a/drivers/scsi/aic94xx/aic94xx_reg.c @@ -123,22 +123,22 @@ static inline u32 asd_mem_offs_swb(void) /* We know that the register wanted is in the range * of the sliding window. */ -#define ASD_READ_SW(ww, type, ord) \ -static type asd_read_##ww##_##ord (struct asd_ha_struct *asd_ha, \ - u32 reg) \ -{ \ - struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ - u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww ();\ - return asd_read_##ord (asd_ha, (unsigned long) map_offs); \ -} - -#define ASD_WRITE_SW(ww, type, ord) \ -static void asd_write_##ww##_##ord (struct asd_ha_struct *asd_ha, \ - u32 reg, type val) \ -{ \ - struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ - u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww ();\ - asd_write_##ord (asd_ha, (unsigned long) map_offs, val); \ +#define ASD_READ_SW(ww, type, ord) \ +static type asd_read_##ww##_##ord(struct asd_ha_struct *asd_ha, \ + u32 reg) \ +{ \ + struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ + return asd_read_##ord (asd_ha, (unsigned long) map_offs); \ +} + +#define ASD_WRITE_SW(ww, type, ord) \ +static void asd_write_##ww##_##ord(struct asd_ha_struct *asd_ha, \ + u32 reg, type val) \ +{ \ + struct asd_ha_addrspace *io_handle = &asd_ha->io_handle[0]; \ + u32 map_offs=(reg - io_handle-> ww##_base )+asd_mem_offs_##ww();\ + asd_write_##ord (asd_ha, (unsigned long)map_offs, val); \ } ASD_READ_SW(swa, u8, byte); _