From: Andrew Morton WARNING: line over 80 characters #28: FILE: drivers/serial/8250_pci.c:112: +addidata_apci7800_setup(struct serial_private *priv, struct pciserial_board *board, ERROR: use tabs not spaces #29: FILE: drivers/serial/8250_pci.c:113: + struct uart_port *port, int idx)$ ERROR: no space before that close parenthesis ')' #34: FILE: drivers/serial/8250_pci.c:118: + if (idx < 2 ) { ERROR: no space before that close parenthesis ')' #39: FILE: drivers/serial/8250_pci.c:123: + } else if ((idx >= 4) && (idx < 6 )) { total: 3 errors, 1 warnings, 180 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Krauth.Julien" Cc: Krauth J. Cc: Russell King Signed-off-by: Andrew Morton --- drivers/serial/8250_pci.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN drivers/serial/8250_pci.c~serial-add-addi-data-gmbh-communication-cardsin8250_pcic-and-pci_idsh-checkpatch-fixes drivers/serial/8250_pci.c --- a/drivers/serial/8250_pci.c~serial-add-addi-data-gmbh-communication-cardsin8250_pcic-and-pci_idsh-checkpatch-fixes +++ a/drivers/serial/8250_pci.c @@ -108,19 +108,19 @@ setup_port(struct serial_private *priv, /* * ADDI-DATA GmbH communication cards */ -static int -addidata_apci7800_setup(struct serial_private *priv, struct pciserial_board *board, - struct uart_port *port, int idx) +static int addidata_apci7800_setup(struct serial_private *priv, + struct pciserial_board *board, + struct uart_port *port, int idx) { unsigned int bar = 0, offset = board->first_offset; bar = FL_GET_BASE(board->flags); - if (idx < 2 ) { + if (idx < 2) { offset += idx * board->uart_offset; } else if ((idx >= 2) && (idx < 4)) { bar += 1; offset += ((idx - 2) * board->uart_offset); - } else if ((idx >= 4) && (idx < 6 )) { + } else if ((idx >= 4) && (idx < 6)) { bar += 2; offset += ((idx - 4) * board->uart_offset); } else if (idx >= 6) { _