From: Andrew Morton WARNING: line over 80 characters #120: FILE: include/linux/wait.h:163: +#define wake_up_interruptible_sync(x) __wake_up_sync((x), TASK_INTERRUPTIBLE, 1) ERROR: use tabs not spaces #399: FILE: kernel/signal.c:1444: + ^IBUG_ON(is_task_stopped_or_traced(tsk));$ total: 1 errors, 1 warnings, 340 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Matthew Wilcox Cc: Matthew Wilcox Signed-off-by: Andrew Morton --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN kernel/signal.c~use-macros-instead-of-task_-flags-checkpatch-fixes kernel/signal.c --- a/kernel/signal.c~use-macros-instead-of-task_-flags-checkpatch-fixes +++ a/kernel/signal.c @@ -1419,7 +1419,7 @@ void do_notify_parent(struct task_struct BUG_ON(sig == -1); /* do_notify_parent_cldstop should have been called instead. */ - BUG_ON(is_task_stopped_or_traced(tsk)); + BUG_ON(is_task_stopped_or_traced(tsk)); BUG_ON(!tsk->ptrace && (tsk->group_leader != tsk || !thread_group_empty(tsk))); _