From: Andrew Morton ERROR: "foo * bar" should be "foo *bar" #152: FILE: fs/dcookies.c:92: +static struct dcookie_struct * alloc_dcookie(struct path *path) ERROR: "foo * bar" should be "foo *bar" #176: FILE: fs/dcookies.c:109: +int get_dcookie(struct path *path, unsigned long * cookie) total: 2 errors, 0 warnings, 205 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jan Blunck Signed-off-by: Andrew Morton --- fs/dcookies.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff -puN fs/dcookies.c~d_path-make-get_dcookie-use-a-struct-path-argument-checkpatch-fixes fs/dcookies.c --- a/fs/dcookies.c~d_path-make-get_dcookie-use-a-struct-path-argument-checkpatch-fixes +++ a/fs/dcookies.c @@ -89,9 +89,10 @@ static void hash_dcookie(struct dcookie_ } -static struct dcookie_struct * alloc_dcookie(struct path *path) +static struct dcookie_struct *alloc_dcookie(struct path *path) { - struct dcookie_struct * dcs = kmem_cache_alloc(dcookie_cache, GFP_KERNEL); + struct dcookie_struct *dcs = kmem_cache_alloc(dcookie_cache, + GFP_KERNEL); if (!dcs) return NULL; @@ -106,7 +107,7 @@ static struct dcookie_struct * alloc_dco /* This is the main kernel-side routine that retrieves the cookie * value for a dentry/vfsmnt pair. */ -int get_dcookie(struct path *path, unsigned long * cookie) +int get_dcookie(struct path *path, unsigned long *cookie) { int err = 0; struct dcookie_struct * dcs; _