From: Andrew Morton WARNING: no space between function name and open parenthesis '(' #24: FILE: drivers/usb/serial/io_ti.c:1089: + dbg ("%s - RUNNING IN DOWNLOAD MODE", __FUNCTION__); WARNING: no space between function name and open parenthesis '(' #29: FILE: drivers/usb/serial/io_ti.c:1093: + dbg ("%s - DOWNLOAD MODE -- BAD I2C", WARNING: no space between function name and open parenthesis '(' #38: FILE: drivers/usb/serial/io_ti.c:1348: + dbg ("%s - RUNNING IN BOOT MODE", WARNING: no space between function name and open parenthesis '(' #47: FILE: drivers/usb/serial/io_ti.c:1464: + dbg ("%s - STAYING IN BOOT MODE", __FUNCTION__); total: 0 errors, 4 warnings, 29 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Greg KH Signed-off-by: Andrew Morton --- drivers/usb/serial/io_ti.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff -puN drivers/usb/serial/io_ti.c~drivers-usb-serial-io_tic-remove-pointless-eye-candy-in-debug-statements-checkpatch-fixes drivers/usb/serial/io_ti.c --- a/drivers/usb/serial/io_ti.c~drivers-usb-serial-io_tic-remove-pointless-eye-candy-in-debug-statements-checkpatch-fixes +++ a/drivers/usb/serial/io_ti.c @@ -1086,12 +1086,11 @@ static int TIDownloadFirmware (struct ed if (serial->product_info.TiMode == TI_MODE_DOWNLOAD) { struct ti_i2c_desc *rom_desc; - dbg ("%s - RUNNING IN DOWNLOAD MODE", __FUNCTION__); + dbg("%s - RUNNING IN DOWNLOAD MODE", __FUNCTION__); status = TiValidateI2cImage (serial); if (status) { - dbg ("%s - DOWNLOAD MODE -- BAD I2C", - __FUNCTION__); + dbg("%s - DOWNLOAD MODE -- BAD I2C", __FUNCTION__); return status; } @@ -1345,8 +1344,7 @@ static int TIDownloadFirmware (struct ed /********************************************************************/ /* Boot Mode */ /********************************************************************/ - dbg ("%s - RUNNING IN BOOT MODE", - __FUNCTION__); + dbg("%s - RUNNING IN BOOT MODE", __FUNCTION__); // Configure the TI device so we can use the BULK pipes for download status = TIConfigureBootDevice (serial->serial->dev); @@ -1461,7 +1459,7 @@ static int TIDownloadFirmware (struct ed StayInBootMode: // Eprom is invalid or blank stay in boot mode - dbg ("%s - STAYING IN BOOT MODE", __FUNCTION__); + dbg("%s - STAYING IN BOOT MODE", __FUNCTION__); serial->product_info.TiMode = TI_MODE_BOOT; return 0; _