From: Andrew Morton WARNING: plain inline is preferred over __inline__ #32: FILE: drivers/char/drm/drm_vm.c:83: +static __inline__ int drm_do_vm_fault(struct vm_area_struct *vma, WARNING: plain inline is preferred over __inline__ #97: FILE: drivers/char/drm/drm_vm.c:155: +static __inline__ int drm_do_vm_fault(struct vm_area_struct *vma, WARNING: plain inline is preferred over __inline__ #111: FILE: drivers/char/drm/drm_vm.c:172: +static __inline__ int drm_do_vm_shm_fault(struct vm_area_struct *vma, WARNING: plain inline is preferred over __inline__ #157: FILE: drivers/char/drm/drm_vm.c:285: +static __inline__ int drm_do_vm_dma_fault(struct vm_area_struct *vma, WARNING: line over 80 characters #176: FILE: drivers/char/drm/drm_vm.c:300: + offset = (unsigned long)vmf->virtual_address - vma->vm_start; /* vm_[pg]off[set] should be 0 */ WARNING: plain inline is preferred over __inline__ #201: FILE: drivers/char/drm/drm_vm.c:320: +static __inline__ int drm_do_vm_sg_fault(struct vm_area_struct *vma, total: 0 errors, 6 warnings, 289 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Dave Airlie Cc: Nick Piggin Signed-off-by: Andrew Morton --- drivers/char/drm/drm_vm.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff -puN drivers/char/drm/drm_vm.c~drm-convert-from-nopage-to-fault-checkpatch-fixes drivers/char/drm/drm_vm.c --- a/drivers/char/drm/drm_vm.c~drm-convert-from-nopage-to-fault-checkpatch-fixes +++ a/drivers/char/drm/drm_vm.c @@ -80,8 +80,7 @@ static pgprot_t drm_io_prot(uint32_t map * map, get the page, increment the use count and return it. */ #if __OS_HAS_AGP -static __inline__ int drm_do_vm_fault(struct vm_area_struct *vma, - struct vm_fault *vmf) +static int drm_do_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { struct drm_file *priv = vma->vm_file->private_data; struct drm_device *dev = priv->head->dev; @@ -152,8 +151,7 @@ vm_fault_error: return VM_FAULT_SIGBUS; /* Disallow mremap */ } #else /* __OS_HAS_AGP */ -static __inline__ int drm_do_vm_fault(struct vm_area_struct *vma, - struct vm_fault *vmf) +static int drm_do_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { return VM_FAULT_SIGBUS; } @@ -169,8 +167,7 @@ static __inline__ int drm_do_vm_fault(st * Get the mapping, find the real physical page to map, get the page, and * return it. */ -static __inline__ int drm_do_vm_shm_fault(struct vm_area_struct *vma, - struct vm_fault *vmf) +static int drm_do_vm_shm_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { struct drm_map *map = (struct drm_map *) vma->vm_private_data; unsigned long offset; @@ -282,8 +279,7 @@ static void drm_vm_shm_close(struct vm_a * * Determine the page number from the page offset and get it from drm_device_dma::pagelist. */ -static __inline__ int drm_do_vm_dma_fault(struct vm_area_struct *vma, - struct vm_fault *vmf) +static int drm_do_vm_dma_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { struct drm_file *priv = vma->vm_file->private_data; struct drm_device *dev = priv->head->dev; @@ -317,8 +313,7 @@ static __inline__ int drm_do_vm_dma_faul * * Determine the map offset from the page offset and get it from drm_sg_mem::pagelist. */ -static __inline__ int drm_do_vm_sg_fault(struct vm_area_struct *vma, - struct vm_fault *vmf) +static int drm_do_vm_sg_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { struct drm_map *map = (struct drm_map *) vma->vm_private_data; struct drm_file *priv = vma->vm_file->private_data; _