From: Andrew Morton WARNING: labels should not be indented #574: FILE: fs/fat/file.c:110: + up_no_drop_write: total: 0 errors, 1 warnings, 844 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Christoph Hellwig Cc: Dave Hansen Signed-off-by: Andrew Morton --- fs/fat/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN fs/fat/file.c~r-o-bind-mounts-elevate-write-count-for-some-ioctls-checkpatch-fixes fs/fat/file.c --- a/fs/fat/file.c~r-o-bind-mounts-elevate-write-count-for-some-ioctls-checkpatch-fixes +++ a/fs/fat/file.c @@ -105,9 +105,9 @@ int fat_generic_ioctl(struct inode *inod MSDOS_I(inode)->i_attrs = attr & ATTR_UNUSED; mark_inode_dirty(inode); - up: +up: mnt_drop_write(filp->f_vfsmnt); - up_no_drop_write: +up_no_drop_write: mutex_unlock(&inode->i_mutex); return err; } _