From: Andrew Morton ERROR: no space after that open parenthesis '(' #63: FILE: security/commoncap.c:209: + bprm->cap_permitted = to_cap_t( le32_to_cpu(caps[1]) ); ERROR: no space before that close parenthesis ')' #63: FILE: security/commoncap.c:209: + bprm->cap_permitted = to_cap_t( le32_to_cpu(caps[1]) ); ERROR: no space after that open parenthesis '(' #64: FILE: security/commoncap.c:210: + bprm->cap_inheritable = to_cap_t( le32_to_cpu(caps[2]) ); ERROR: no space before that close parenthesis ')' #64: FILE: security/commoncap.c:210: + bprm->cap_inheritable = to_cap_t( le32_to_cpu(caps[2]) ); total: 4 errors, 0 warnings, 71 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andrew Morgan Cc: Casey Schaufler Cc: Chris Wright Cc: James Morris Cc: Serge Hallyn Cc: Stephen Smalley Signed-off-by: Andrew Morton --- security/commoncap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN security/commoncap.c~revert-capabilities-clean-up-file-capability-reading-checkpatch-fixes security/commoncap.c --- a/security/commoncap.c~revert-capabilities-clean-up-file-capability-reading-checkpatch-fixes +++ a/security/commoncap.c @@ -213,8 +213,8 @@ static inline int cap_from_disk(__le32 * bprm->cap_effective = true; else bprm->cap_effective = false; - bprm->cap_permitted = to_cap_t( le32_to_cpu(caps[1]) ); - bprm->cap_inheritable = to_cap_t( le32_to_cpu(caps[2]) ); + bprm->cap_permitted = to_cap_t(le32_to_cpu(caps[1])); + bprm->cap_inheritable = to_cap_t(le32_to_cpu(caps[2])); return 0; default: return -EINVAL; _