From: Andrew Morton ERROR: use tabs not spaces #81: FILE: fs/nfsd/export.c:630: + ^Ikfree(exp.ex_pathname);$ WARNING: kfree(NULL) is safe this check is probabally not required #214: FILE: fs/nfsd/export.c:1092: + if (new.ex_pathname) + kfree(new.ex_pathname); ERROR: no space after that '!' (ctx:WxW) #326: FILE: fs/nfsd/nfsfh.c:49: + while (tdentry != exp->ex_path.dentry && ! IS_ROOT(tdentry)) { ^ WARNING: line over 80 characters #370: FILE: fs/nfsd/nfsfh.c:338: + int root_export = (exp->ex_path.dentry == exp->ex_path.dentry->d_sb->s_root); WARNING: line over 80 characters #384: FILE: fs/nfsd/nfsfh.c:384: + if (!(exp->ex_path.dentry->d_inode->i_sb->s_type->fs_flags WARNING: line over 80 characters #411: FILE: fs/nfsd/nfsfh.c:564: + if (fhp->fh_export->ex_path.dentry->d_inode->i_sb->s_type->fs_flags WARNING: braces {} are not necessary for single statement blocks #474: FILE: fs/nfsd/vfs.c:159: + else if (dparent != exp->ex_path.dentry) { dentry = dget_parent(dparent); } else if (!EX_NOHIDE(exp)) WARNING: line over 80 characters #492: FILE: fs/nfsd/vfs.c:724: + *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), flags); WARNING: line over 80 characters #545: FILE: fs/nfsd/vfs.c:1880: + if (exp_rdonly(rqstp, exp) || __mnt_is_readonly(exp->ex_path.mnt)) ERROR: "foo * bar" should be "foo *bar" #560: FILE: include/linux/nfsd/export.h:88: + char * ex_pathname; total: 3 errors, 7 warnings, 459 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: J. Bruce Fields Cc: Jan Blunck Cc: Neil Brown Signed-off-by: Andrew Morton --- fs/nfsd/export.c | 5 ++--- fs/nfsd/nfsfh.c | 2 +- fs/nfsd/vfs.c | 7 ++++--- include/linux/nfsd/export.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff -puN fs/nfsd/export.c~use-struct-path-in-struct-svc_export-checkpatch-fixes fs/nfsd/export.c --- a/fs/nfsd/export.c~use-struct-path-in-struct-svc_export-checkpatch-fixes +++ a/fs/nfsd/export.c @@ -627,7 +627,7 @@ static int svc_export_parse(struct cache out: nfsd4_fslocs_free(&exp.ex_fslocs); kfree(exp.ex_uuid); - kfree(exp.ex_pathname); + kfree(exp.ex_pathname); if (nd.path.dentry) path_put(&nd.path); out_no_path: @@ -1088,8 +1088,7 @@ exp_export(struct nfsctl_export *nxp) } else err = 0; finish: - if (new.ex_pathname) - kfree(new.ex_pathname); + kfree(new.ex_pathname); if (exp) exp_put(exp); if (fsid_key && !IS_ERR(fsid_key)) diff -puN fs/nfsd/nfsfh.c~use-struct-path-in-struct-svc_export-checkpatch-fixes fs/nfsd/nfsfh.c --- a/fs/nfsd/nfsfh.c~use-struct-path-in-struct-svc_export-checkpatch-fixes +++ a/fs/nfsd/nfsfh.c @@ -46,7 +46,7 @@ static int nfsd_acceptable(void *expv, s return 1; tdentry = dget(dentry); - while (tdentry != exp->ex_path.dentry && ! IS_ROOT(tdentry)) { + while (tdentry != exp->ex_path.dentry && !IS_ROOT(tdentry)) { /* make sure parents give x permission to user */ int err; parent = dget_parent(tdentry); diff -puN fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-checkpatch-fixes fs/nfsd/vfs.c --- a/fs/nfsd/vfs.c~use-struct-path-in-struct-svc_export-checkpatch-fixes +++ a/fs/nfsd/vfs.c @@ -156,9 +156,9 @@ nfsd_lookup_dentry(struct svc_rqst *rqst if (isdotent(name, len)) { if (len==1) dentry = dget(dparent); - else if (dparent != exp->ex_path.dentry) { + else if (dparent != exp->ex_path.dentry) dentry = dget_parent(dparent); - } else if (!EX_NOHIDE(exp)) + else if (!EX_NOHIDE(exp)) dentry = dget(dparent); /* .. == . just like at / */ else { /* checking mountpoint crossing is very different when stepping up */ @@ -721,7 +721,8 @@ nfsd_open(struct svc_rqst *rqstp, struct DQUOT_INIT(inode); } - *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), flags); + *filp = dentry_open(dget(dentry), mntget(fhp->fh_export->ex_path.mnt), + flags); if (IS_ERR(*filp)) host_err = PTR_ERR(*filp); out_nfserr: diff -puN include/linux/nfsd/export.h~use-struct-path-in-struct-svc_export-checkpatch-fixes include/linux/nfsd/export.h --- a/include/linux/nfsd/export.h~use-struct-path-in-struct-svc_export-checkpatch-fixes +++ a/include/linux/nfsd/export.h @@ -85,7 +85,7 @@ struct svc_export { struct auth_domain * ex_client; int ex_flags; struct path ex_path; - char * ex_pathname; + char *ex_pathname; uid_t ex_anon_uid; gid_t ex_anon_gid; int ex_fsid; _