From: Andrew Morton WARNING: printk() should include KERN_ facility level #201: FILE: drivers/char/ipmi/ipmi_bt_sm.c:384: + printk(" %02x", bt->read_data[i]); ERROR: no space before that '++' (ctx:WxB) #475: FILE: drivers/char/ipmi/ipmi_kcs_sm.c:295: + for (i = 0; i < size; i ++) ^ ERROR: need space after that ',' (ctx:VxO) #1703: FILE: drivers/char/ipmi/ipmi_si_sm.h:70: + SI_SM_CALL_WITH_TICK_DELAY,/* Delay >=1 tick before calling again. */ ^ total: 2 errors, 1 warnings, 1977 lines checked ./patches/ipmi-style-fixes-in-the-system-interface-code.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Corey Minyard Cc: Hannes Schulz Cc: Rocky Craig Signed-off-by: Andrew Morton --- drivers/char/ipmi/ipmi_bt_sm.c | 4 ++-- drivers/char/ipmi/ipmi_kcs_sm.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/char/ipmi/ipmi_bt_sm.c~ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes drivers/char/ipmi/ipmi_bt_sm.c --- a/drivers/char/ipmi/ipmi_bt_sm.c~ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes +++ a/drivers/char/ipmi/ipmi_bt_sm.c @@ -381,8 +381,8 @@ static inline int read_all_bytes(struct if (max > 16) max = 16; for (i = 0; i < max; i++) - printk(" %02x", bt->read_data[i]); - printk("%s\n", bt->read_count == max ? "" : " ..."); + printk(KERN_CONT " %02x", bt->read_data[i]); + printk(KERN_CONT "%s\n", bt->read_count == max ? "" : " ..."); } /* per the spec, the (NetFn[1], Seq[2], Cmd[3]) tuples must match */ diff -puN drivers/char/ipmi/ipmi_kcs_sm.c~ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes drivers/char/ipmi/ipmi_kcs_sm.c --- a/drivers/char/ipmi/ipmi_kcs_sm.c~ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes +++ a/drivers/char/ipmi/ipmi_kcs_sm.c @@ -292,7 +292,7 @@ static int start_kcs_transaction(struct if (kcs_debug & KCS_DEBUG_MSG) { printk(KERN_DEBUG "start_kcs_transaction -"); - for (i = 0; i < size; i ++) + for (i = 0; i < size; i++) printk(" %02x", (unsigned char) (data [i])); printk("\n"); } _