From: Andrew Morton ERROR: need spaces around that '=' (ctx:VxV) #185: FILE: drivers/mfd/sm501.c:563: + reg=to.shift & 0x07;/* bottom 3 bits are shift */ ^ ERROR: need spaces around that '=' (ctx:VxV) #195: FILE: drivers/mfd/sm501.c:573: + reg=to.shift & 0x07;/* bottom 3 bits are shift */ ^ total: 2 errors, 0 warnings, 250 lines checked ./patches/sm501-add-support-for-the-sm502-programmable-pll.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Ben Dooks Cc: Ville Syrjala Signed-off-by: Andrew Morton --- drivers/mfd/sm501.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/mfd/sm501.c~sm501-add-support-for-the-sm502-programmable-pll-checkpatch-fixes drivers/mfd/sm501.c --- a/drivers/mfd/sm501.c~sm501-add-support-for-the-sm502-programmable-pll-checkpatch-fixes +++ a/drivers/mfd/sm501.c @@ -560,7 +560,7 @@ unsigned long sm501_set_clock(struct dev /* SM502 -> use the programmable PLL */ sm501_freq = (sm501_calc_pll(2 * req_freq, &to, 5) / 2); - reg=to.shift & 0x07;/* bottom 3 bits are shift */ + reg = to.shift & 0x07;/* bottom 3 bits are shift */ if (to.divider == 3) reg |= 0x08; /* /3 divider required */ else if (to.divider == 5) @@ -570,7 +570,7 @@ unsigned long sm501_set_clock(struct dev } else { sm501_freq = (sm501_select_clock(2 * req_freq, &to, 5) / 2); - reg=to.shift & 0x07;/* bottom 3 bits are shift */ + reg = to.shift & 0x07;/* bottom 3 bits are shift */ if (to.divider == 3) reg |= 0x08; /* /3 divider required */ else if (to.divider == 5) _