From: Harvey Harrison fs/jffs2/write.c:585:28: warning: symbol 'fd' shadows an earlier one fs/jffs2/write.c:536:27: originally declared here No need to redeclare fd, use the original one, after this point, fd is always reassigned before it used again. Signed-off-by: Harvey Harrison Cc: David Woodhouse Signed-off-by: Andrew Morton --- fs/jffs2/write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN fs/jffs2/write.c~jffs2-fix-sparse-warning-in-writec fs/jffs2/write.c --- a/fs/jffs2/write.c~jffs2-fix-sparse-warning-in-writec +++ a/fs/jffs2/write.c @@ -582,9 +582,9 @@ int jffs2_do_unlink(struct jffs2_sb_info jffs2_add_fd_to_list(c, fd, &dir_f->dents); up(&dir_f->sem); } else { - struct jffs2_full_dirent *fd = dir_f->dents; uint32_t nhash = full_name_hash(name, namelen); + fd = dir_f->dents; /* We don't actually want to reserve any space, but we do want to be holding the alloc_sem when we write to flash */ down(&c->alloc_sem); _