From: Andrew Morton WARNING: printk() should include KERN_ facility level #53: FILE: drivers/char/sysrq.c:210: + printk("CPU%d:\n", smp_processor_id()); WARNING: printk() should include KERN_ facility level #67: FILE: drivers/char/sysrq.c:224: + printk("CPU%d:\n", smp_processor_id()); total: 0 errors, 2 warnings, 63 lines checked ./patches/sysrq-add-show-backtrace-on-all-cpus-function.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Cc: Ingo Molnar Cc: Rik van Riel Signed-off-by: Andrew Morton --- drivers/char/sysrq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/char/sysrq.c~sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes drivers/char/sysrq.c --- a/drivers/char/sysrq.c~sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes +++ a/drivers/char/sysrq.c @@ -207,7 +207,7 @@ static void showacpu(void *dummy) return; spin_lock_irqsave(&show_lock, flags); - printk("CPU%d:\n", smp_processor_id()); + printk(KERN_INFO "CPU%d:\n", smp_processor_id()); show_stack(NULL, NULL); spin_unlock_irqrestore(&show_lock, flags); } @@ -221,7 +221,7 @@ static void sysrq_handle_showallcpus(int { struct pt_regs *regs = get_irq_regs(); if (regs) { - printk("CPU%d:\n", smp_processor_id()); + printk(KERN_INFO "CPU%d:\n", smp_processor_id()); show_regs(regs); } schedule_work(&sysrq_showallcpus); _