From alan@lxorguk.ukuu.org.uk Wed Feb 20 14:28:30 2008 From: Alan Cox Date: Wed, 20 Feb 2008 20:51:45 +0000 Subject: USB: serial: Note mos7480 and option don't lock modem status To: akpm@osdl.org, greg@kroah.com, linux-usb@vger.kernel.org Message-ID: <20080220205145.2e0a61f9@core> Signed-off-by: Alan Cox Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/mos7840.c | 1 + drivers/usb/serial/option.c | 1 + 2 files changed, 2 insertions(+) --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_s if (mos7840_port == NULL) return -ENODEV; + /* FIXME: What locks the port registers ? */ mcr = mos7840_port->shadowMCR; if (clear & TIOCM_RTS) mcr &= ~MCR_RTS; --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -406,6 +406,7 @@ static int option_tiocmset(struct usb_se portdata = usb_get_serial_port_data(port); + /* FIXME: what locks portdata fields ? */ if (set & TIOCM_RTS) portdata->rts_state = 1; if (set & TIOCM_DTR)