From: Roel Kluin <12o3l@tiscali.nl> logical-bitwise & confusion Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Cc: Mark M. Hoffman Acked-by: Colin Leroy Cc: Benjamin Herrenschmidt Cc: Segher Boessenkool Cc: "Darrick J. Wong" Signed-off-by: Andrew Morton --- drivers/hwmon/adt7473.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/hwmon/adt7473.c~adt746x-logical-bitwise-confusion-in-set_max_duty_at_crit drivers/hwmon/adt7473.c --- a/drivers/hwmon/adt7473.c~adt746x-logical-bitwise-confusion-in-set_max_duty_at_crit +++ a/drivers/hwmon/adt7473.c @@ -573,11 +573,11 @@ static ssize_t set_max_duty_at_crit(stru const char *buf, size_t count) { - u8 reg; + u8 reg, temp; struct i2c_client *client = to_i2c_client(dev); struct adt7473_data *data = i2c_get_clientdata(client); - int temp = simple_strtol(buf, NULL, 10); - temp = temp && 0xFF; + + temp = simple_strtol(buf, NULL, 10); mutex_lock(&data->lock); data->max_duty_at_overheat = temp; _