From: Andrew Morton ERROR: do not use assignment in if condition #25: FILE: drivers/char/epca.c:926: + if ((bc = ch->brdchan) == NULL) { WARNING: no space between function name and open parenthesis '(' #52: FILE: drivers/char/epca.c:2868: +static int __init init_PCI (void) total: 1 errors, 1 warnings, 32 lines checked ./patches/epcac-static-functions-and-integer-as-null-pointer-fixes.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Harvey Harrison Signed-off-by: Andrew Morton --- drivers/char/epca.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -puN drivers/char/epca.c~epcac-static-functions-and-integer-as-null-pointer-fixes-checkpatch-fixes drivers/char/epca.c --- a/drivers/char/epca.c~epcac-static-functions-and-integer-as-null-pointer-fixes-checkpatch-fixes +++ a/drivers/char/epca.c @@ -923,7 +923,8 @@ static int pc_open(struct tty_struct *tt return(-ENODEV); } - if ((bc = ch->brdchan) == NULL) { + bc = ch->brdchan; + if (bc == NULL) { tty->driver_data = NULL; return -ENODEV; } @@ -2865,7 +2866,7 @@ static struct pci_device_id epca_pci_tbl MODULE_DEVICE_TABLE(pci, epca_pci_tbl); -static int __init init_PCI (void) +static int __init init_PCI(void) { memset (&epca_driver, 0, sizeof (epca_driver)); epca_driver.name = "epca"; _