From: Andrew Morton WARNING: braces {} are not necessary for single statement blocks #40: FILE: sound/pci/es1968.c:1831: + if (diff > 1) { + __maestro_write(chip, IDR0_DATA_PORT, cp1); + } total: 0 errors, 1 warnings, 35 lines checked ./patches/es1968-fix-jitter-on-some-maestro-cards.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andreas Mueller Cc: Jaroslav Kysela Tested-by: Rene Herman Cc: Takashi Iwai Signed-off-by: Andrew Morton --- sound/pci/es1968.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN sound/pci/es1968.c~es1968-fix-jitter-on-some-maestro-cards-checkpatch-fixes sound/pci/es1968.c --- a/sound/pci/es1968.c~es1968-fix-jitter-on-some-maestro-cards-checkpatch-fixes +++ a/sound/pci/es1968.c @@ -1828,9 +1828,8 @@ static void snd_es1968_suppress_jitter(s cp2 = __apu_get_register(chip, 1, 5); diff = (cp1 > cp2 ? cp1 - cp2 : cp2 - cp1); - if (diff > 1) { + if (diff > 1) __maestro_write(chip, IDR0_DATA_PORT, cp1); - } } /* _