From: Andrew Morton ERROR: open brace '{' following struct go on the same line #49: FILE: kernel/module.c:995: +struct module_sect_attr +{ ERROR: open brace '{' following struct go on the same line #56: FILE: kernel/module.c:1002: +struct module_sect_attrs +{ total: 2 errors, 0 warnings, 51 lines checked ./patches/make-module_sect_attrs-private-to-kernel-modulec.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Jan Beulich" Cc: Jan Beulich Cc: Rusty Russell Signed-off-by: Andrew Morton --- kernel/module.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff -puN kernel/module.c~make-module_sect_attrs-private-to-kernel-modulec-checkpatch-fixes kernel/module.c --- a/kernel/module.c~make-module_sect_attrs-private-to-kernel-modulec-checkpatch-fixes +++ a/kernel/module.c @@ -992,15 +992,13 @@ static unsigned long resolve_symbol(Elf_ * J. Corbet */ #if defined(CONFIG_KALLSYMS) && defined(CONFIG_SYSFS) -struct module_sect_attr -{ +struct module_sect_attr { struct module_attribute mattr; char *name; unsigned long address; }; -struct module_sect_attrs -{ +struct module_sect_attrs { struct attribute_group grp; unsigned int nsections; struct module_sect_attr attrs[0]; _