From: Andrew Morton be conventional about code layout. Cc: Cc: Ingo Molnar Cc: Rik van Riel Signed-off-by: Andrew Morton --- drivers/char/sysrq.c | 4 ++++ 1 file changed, 4 insertions(+) diff -puN drivers/char/sysrq.c~sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes-cleanup drivers/char/sysrq.c --- a/drivers/char/sysrq.c~sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes-cleanup +++ a/drivers/char/sysrq.c @@ -198,6 +198,7 @@ static struct sysrq_key_op sysrq_showloc #ifdef CONFIG_SMP static DEFINE_SPINLOCK(show_lock); + static void showacpu(void *dummy) { unsigned long flags; @@ -211,10 +212,12 @@ static void showacpu(void *dummy) show_stack(NULL, NULL); spin_unlock_irqrestore(&show_lock, flags); } + static void sysrq_showregs_othercpus(struct work_struct *dummy) { smp_call_function(showacpu, NULL, 0, 0); } + static DECLARE_WORK(sysrq_showallcpus, sysrq_showregs_othercpus); static void sysrq_handle_showallcpus(int key, struct tty_struct *tty) @@ -226,6 +229,7 @@ static void sysrq_handle_showallcpus(int } schedule_work(&sysrq_showallcpus); } + static struct sysrq_key_op sysrq_showallcpus_op = { .handler = sysrq_handle_showallcpus, .help_msg = "aLlcpus", _