From: Andrew Morton ERROR: "foo * bar" should be "foo *bar" #24: FILE: drivers/oprofile/buffer_sync.c:497: + struct oprofile_cpu_buffer * cpu_buf = &per_cpu(cpu_buffer, cpu); ERROR: "foo * bar" should be "foo *bar" #54: FILE: drivers/oprofile/cpu_buffer.c:52: + struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); ERROR: "foo * bar" should be "foo *bar" #63: FILE: drivers/oprofile/cpu_buffer.c:86: + struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); ERROR: "foo * bar" should be "foo *bar" #72: FILE: drivers/oprofile/cpu_buffer.c:103: + struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); ERROR: "foo * bar" should be "foo *bar" #81: FILE: drivers/oprofile/cpu_buffer.c:230: + struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); ERROR: "foo * bar" should be "foo *bar" #90: FILE: drivers/oprofile/cpu_buffer.c:257: + struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); ERROR: "foo * bar" should be "foo *bar" #97: FILE: drivers/oprofile/cpu_buffer.c:263: + struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); total: 7 errors, 0 warnings, 102 lines checked ./patches/oprofile-change-cpu_buffer-from-array-to-per_cpu-variable.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Mike Travis Cc: Philippe Elie Signed-off-by: Andrew Morton --- drivers/oprofile/buffer_sync.c | 2 +- drivers/oprofile/cpu_buffer.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff -puN drivers/oprofile/buffer_sync.c~oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes drivers/oprofile/buffer_sync.c --- a/drivers/oprofile/buffer_sync.c~oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes +++ a/drivers/oprofile/buffer_sync.c @@ -491,7 +491,7 @@ typedef enum { */ void sync_buffer(int cpu) { - struct oprofile_cpu_buffer * cpu_buf = &per_cpu(cpu_buffer, cpu); + struct oprofile_cpu_buffer *cpu_buf = &per_cpu(cpu_buffer, cpu); struct mm_struct *mm = NULL; struct task_struct * new; unsigned long cookie = 0; diff -puN drivers/oprofile/cpu_buffer.c~oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes drivers/oprofile/cpu_buffer.c --- a/drivers/oprofile/cpu_buffer.c~oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes +++ a/drivers/oprofile/cpu_buffer.c @@ -49,7 +49,7 @@ int alloc_cpu_buffers(void) unsigned long buffer_size = fs_cpu_buffer_size; for_each_online_cpu(i) { - struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); + struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i); b->buffer = vmalloc_node(sizeof(struct op_sample) * buffer_size, cpu_to_node(i)); @@ -83,7 +83,7 @@ void start_cpu_work(void) work_enabled = 1; for_each_online_cpu(i) { - struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); + struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i); /* * Spread the work by 1 jiffy per cpu so they dont all @@ -100,7 +100,7 @@ void end_cpu_work(void) work_enabled = 0; for_each_online_cpu(i) { - struct oprofile_cpu_buffer * b = &per_cpu(cpu_buffer, i); + struct oprofile_cpu_buffer *b = &per_cpu(cpu_buffer, i); cancel_delayed_work(&b->work); } @@ -227,7 +227,7 @@ static void oprofile_end_trace(struct op void oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, unsigned long event, int is_kernel) { - struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); + struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer); if (!backtrace_depth) { log_sample(cpu_buf, pc, is_kernel, event); @@ -254,13 +254,13 @@ void oprofile_add_sample(struct pt_regs void oprofile_add_pc(unsigned long pc, int is_kernel, unsigned long event) { - struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); + struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer); log_sample(cpu_buf, pc, is_kernel, event); } void oprofile_add_trace(unsigned long pc) { - struct oprofile_cpu_buffer * cpu_buf = &__get_cpu_var(cpu_buffer); + struct oprofile_cpu_buffer *cpu_buf = &__get_cpu_var(cpu_buffer); if (!cpu_buf->tracing) return; _