From: Andrew Morton ERROR: do not initialise statics to 0 or NULL #105: FILE: mm/hugetlb.c:28: +static int max_hstate = 0; ERROR: do not initialise statics to 0 or NULL #110: FILE: mm/hugetlb.c:33: +static struct hstate * __initdata parsed_hstate = NULL; ERROR: do not initialise statics to 0 or NULL #111: FILE: mm/hugetlb.c:34: +static unsigned long __initdata default_hstate_max_huge_pages = 0; total: 3 errors, 0 warnings, 279 lines checked ./patches/hugetlb-multiple-hstates-for-multiple-page-sizes.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Adam Litke Cc: Andi Kleen Cc: Nick Piggin Cc: Nishanth Aravamudan Signed-off-by: Andrew Morton --- mm/hugetlb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN mm/hugetlb.c~hugetlb-multiple-hstates-for-multiple-page-sizes-checkpatch-fixes mm/hugetlb.c --- a/mm/hugetlb.c~hugetlb-multiple-hstates-for-multiple-page-sizes-checkpatch-fixes +++ a/mm/hugetlb.c @@ -25,13 +25,13 @@ const unsigned long hugetlb_zero = 0, hu static gfp_t htlb_alloc_mask = GFP_HIGHUSER; unsigned long hugepages_treat_as_movable; -static int max_hstate = 0; +static int max_hstate; unsigned int default_hstate_idx; struct hstate hstates[HUGE_MAX_HSTATE]; /* for command line parsing */ -static struct hstate * __initdata parsed_hstate = NULL; -static unsigned long __initdata default_hstate_max_huge_pages = 0; +static struct hstate * __initdata parsed_hstate; +static unsigned long __initdata default_hstate_max_huge_pages; #define for_each_hstate(h) \ for ((h) = hstates; (h) < &hstates[max_hstate]; (h)++) _