From: Andrew Morton WARNING: space prohibited between function name and open parenthesis '(' #46: FILE: drivers/char/agp/generic.c:430: + list_add (&curr->mapped_list, &agp_bridge->mapped_list); WARNING: space prohibited between function name and open parenthesis '(' #57: FILE: drivers/char/agp/generic.c:466: + list_del (&curr->mapped_list); WARNING: space prohibited between function name and open parenthesis '(' #67: FILE: drivers/char/agp/generic.c:475: +int agp_rebind_memory (void) WARNING: space prohibited between function name and open parenthesis '(' #92: FILE: include/linux/agp_backend.h:111: +extern int agp_rebind_memory (void); total: 0 errors, 4 warnings, 62 lines checked ./patches/intel-agp-rewrite-gtt-on-resume-update.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Keith Packard Signed-off-by: Andrew Morton --- drivers/char/agp/generic.c | 6 +++--- include/linux/agp_backend.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/char/agp/generic.c~intel-agp-rewrite-gtt-on-resume-update-checkpatch-fixes drivers/char/agp/generic.c --- a/drivers/char/agp/generic.c~intel-agp-rewrite-gtt-on-resume-update-checkpatch-fixes +++ a/drivers/char/agp/generic.c @@ -427,7 +427,7 @@ int agp_bind_memory(struct agp_memory *c curr->is_bound = TRUE; curr->pg_start = pg_start; spin_lock(&agp_bridge->mapped_lock); - list_add (&curr->mapped_list, &agp_bridge->mapped_list); + list_add(&curr->mapped_list, &agp_bridge->mapped_list); spin_unlock(&agp_bridge->mapped_lock); return 0; @@ -463,7 +463,7 @@ int agp_unbind_memory(struct agp_memory curr->is_bound = FALSE; curr->pg_start = 0; spin_lock(&curr->bridge->mapped_lock); - list_del (&curr->mapped_list); + list_del(&curr->mapped_list); spin_unlock(&curr->bridge->mapped_lock); return 0; } @@ -472,7 +472,7 @@ EXPORT_SYMBOL(agp_unbind_memory); /** * agp_rebind_emmory - Rewrite the entire GATT, useful on resume */ -int agp_rebind_memory (void) +int agp_rebind_memory(void) { struct agp_memory *curr; int ret_val; diff -puN include/linux/agp_backend.h~intel-agp-rewrite-gtt-on-resume-update-checkpatch-fixes include/linux/agp_backend.h --- a/include/linux/agp_backend.h~intel-agp-rewrite-gtt-on-resume-update-checkpatch-fixes +++ a/include/linux/agp_backend.h @@ -108,7 +108,7 @@ extern struct agp_memory *agp_allocate_m extern int agp_copy_info(struct agp_bridge_data *, struct agp_kern_info *); extern int agp_bind_memory(struct agp_memory *, off_t); extern int agp_unbind_memory(struct agp_memory *); -extern int agp_rebind_memory (void); +extern int agp_rebind_memory(void); extern void agp_enable(struct agp_bridge_data *, u32); extern struct agp_bridge_data *agp_backend_acquire(struct pci_dev *); extern void agp_backend_release(struct agp_bridge_data *); _