From: Andrew Morton WARNING: line over 80 characters #26: FILE: include/linux/sem.h:98: + struct list_head list_id; /* undo requests on this array */ WARNING: line over 80 characters #36: FILE: include/linux/sem.h:121: + struct list_head list_proc; /* per-process list: all undos from one process */ WARNING: line over 80 characters #37: FILE: include/linux/sem.h:122: + struct list_head list_id; /* per semaphore array list: all undos for one array */ ERROR: spaces required around that '==' (ctx:VxV) #135: FILE: ipc/sem.c:976: + if(walk->semid==semid) ^ ERROR: space required before the open parenthesis '(' #135: FILE: ipc/sem.c:976: + if(walk->semid==semid) ERROR: spaces required around that '==' (ctx:VxO) #137: FILE: ipc/sem.c:978: + if(walk->semid==-1) { ^ ERROR: space required before that '-' (ctx:OxV) #137: FILE: ipc/sem.c:978: + if(walk->semid==-1) { ^ ERROR: space required before the open parenthesis '(' #137: FILE: ipc/sem.c:978: + if(walk->semid==-1) { ERROR: spaces required around that '=' (ctx:VxW) #258: FILE: ipc/sem.c:1271: + ulp= tsk->sysvsem.undo_list; ^ ERROR: code indent should use tabs where possible #285: FILE: ipc/sem.c:1282: + ^I^Istruct sem_array *sma;$ ERROR: space required before the open parenthesis '(' #288: FILE: ipc/sem.c:1285: + if(un->semid == -1) total: 8 errors, 3 warnings, 308 lines checked ./patches/ipc-semc-convert-undo-structures-to-struct-list_head.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Manfred Spraul Cc: Nadia Derbey Cc: Pierre Peiffer Signed-off-by: Andrew Morton --- ipc/sem.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff -puN ipc/sem.c~ipc-semc-convert-undo-structures-to-struct-list_head-checkpatch-fixes ipc/sem.c --- a/ipc/sem.c~ipc-semc-convert-undo-structures-to-struct-list_head-checkpatch-fixes +++ a/ipc/sem.c @@ -973,9 +973,9 @@ static struct sem_undo *lookup_undo(stru assert_spin_locked(&ulp->lock); list_for_each_entry_safe(walk, tmp, &ulp->list_proc, list_proc) { - if(walk->semid==semid) + if (walk->semid == semid) return walk; - if(walk->semid==-1) { + if (walk->semid == -1) { list_del(&walk->list_proc); kfree(walk); } @@ -1268,7 +1268,7 @@ void exit_sem(struct task_struct *tsk) struct sem_undo_list *ulp; struct sem_undo *un, *tmp; - ulp= tsk->sysvsem.undo_list; + ulp = tsk->sysvsem.undo_list; if (!ulp) return; tsk->sysvsem.undo_list = NULL; @@ -1279,10 +1279,10 @@ void exit_sem(struct task_struct *tsk) spin_lock(&ulp->lock); list_for_each_entry_safe(un, tmp, &ulp->list_proc, list_proc) { - struct sem_array *sma; + struct sem_array *sma; int i; - if(un->semid == -1) + if (un->semid == -1) goto free; sma = sem_lock(tsk->nsproxy->ipc_ns, un->semid); _