From: Andrew Morton WARNING: line over 80 characters #42: FILE: include/linux/sem.h:118: + struct list_head list_proc; /* per-process list: all undos from one process. */ WARNING: line over 80 characters #45: FILE: include/linux/sem.h:121: + struct sem_undo_list *ulp; /* sem_undo_list for the process */ WARNING: line over 80 characters #167: FILE: ipc/sem.c:1025: + /* step 4: check for races: did someone else allocate the undo struct? */ ERROR: space required before the open parenthesis '(' #213: FILE: ipc/sem.c:1126: + if(un->semid == -1) { ERROR: spaces required around that '=' (ctx:WxV) #255: FILE: ipc/sem.c:1284: + un =list_entry(rcu_dereference(ulp->list_proc.next), ^ ERROR: space required before the open parenthesis '(' #266: FILE: ipc/sem.c:1292: + if(semid == -1) total: 3 errors, 3 warnings, 272 lines checked ./patches/ipc-semc-rewrite-undo-list-locking.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Manfred Spraul Cc: Nadia Derbey Cc: Pierre Peiffer Signed-off-by: Andrew Morton --- ipc/sem.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff -puN ipc/sem.c~ipc-semc-rewrite-undo-list-locking-checkpatch-fixes ipc/sem.c --- a/ipc/sem.c~ipc-semc-rewrite-undo-list-locking-checkpatch-fixes +++ a/ipc/sem.c @@ -1022,7 +1022,9 @@ static struct sem_undo *find_alloc_undo( } spin_lock(&ulp->lock); - /* step 4: check for races: did someone else allocate the undo struct? */ + /* + * step 4: check for races: did someone else allocate the undo struct? + */ un = lookup_undo(ulp, semid); if (un) { kfree(new); @@ -1123,7 +1125,7 @@ asmlinkage long sys_semtimedop(int semid */ error = -EIDRM; if (un) { - if(un->semid == -1) { + if (un->semid == -1) { rcu_read_unlock(); goto out_unlock_free; } else { @@ -1281,7 +1283,7 @@ void exit_sem(struct task_struct *tsk) int i; rcu_read_lock(); - un =list_entry(rcu_dereference(ulp->list_proc.next), + un = list_entry(rcu_dereference(ulp->list_proc.next), struct sem_undo, list_proc); if (&un->list_proc == &ulp->list_proc) semid = -1; @@ -1289,7 +1291,7 @@ void exit_sem(struct task_struct *tsk) semid = un->semid; rcu_read_unlock(); - if(semid == -1) + if (semid == -1) break; sma = sem_lock_check(tsk->nsproxy->ipc_ns, un->semid); _