From: "Robert P. J. Day" Remove the conditional surrounding the definition of list_add() from list.h since, if you define CONFIG_DEBUG_LIST, the definition you will subsequently pick up from lib/list_debug.c will be absolutely identical, at which point you can remove that redundant definition from list_debug.c as well. Signed-off-by: Robert P. J. Day Cc: Dave Jones Signed-off-by: Andrew Morton --- include/linux/list.h | 4 ---- lib/list_debug.c | 14 -------------- 2 files changed, 18 deletions(-) diff -puN include/linux/list.h~lists-remove-a-redundant-conditional-definition-of-list_add include/linux/list.h --- a/include/linux/list.h~lists-remove-a-redundant-conditional-definition-of-list_add +++ a/include/linux/list.h @@ -61,14 +61,10 @@ extern void __list_add(struct list_head * Insert a new entry after the specified head. * This is good for implementing stacks. */ -#ifndef CONFIG_DEBUG_LIST static inline void list_add(struct list_head *new, struct list_head *head) { __list_add(new, head, head->next); } -#else -extern void list_add(struct list_head *new, struct list_head *head); -#endif /** diff -puN lib/list_debug.c~lists-remove-a-redundant-conditional-definition-of-list_add lib/list_debug.c --- a/lib/list_debug.c~lists-remove-a-redundant-conditional-definition-of-list_add +++ a/lib/list_debug.c @@ -40,20 +40,6 @@ void __list_add(struct list_head *new, EXPORT_SYMBOL(__list_add); /** - * list_add - add a new entry - * @new: new entry to be added - * @head: list head to add it after - * - * Insert a new entry after the specified head. - * This is good for implementing stacks. - */ -void list_add(struct list_head *new, struct list_head *head) -{ - __list_add(new, head, head->next); -} -EXPORT_SYMBOL(list_add); - -/** * list_del - deletes entry from list. * @entry: the element to delete from the list. * Note: list_empty on entry does not return true after this, the entry is _