From: Andrew Morton WARNING: Use #include instead of #87: FILE: drivers/net/sh_eth.c:32: +#include WARNING: Use #include instead of #88: FILE: drivers/net/sh_eth.c:33: +#include ERROR: space prohibited after that open parenthesis '(' #674: FILE: drivers/net/sh_eth.c:619: + mod_timer( &mdp->timer, jiffies + (10 * HZ)); total: 1 errors, 2 warnings, 1663 lines checked ./patches/net-sh_eth-add-support-for-renesas-superh-ethernet.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches (akpm: also remove unused next_tick) Cc: Jeff Garzik Cc: Nobuhiro Iwamatsu Cc: Paul Mundt Cc: Yoshihiro Shimoda Signed-off-by: Andrew Morton --- drivers/net/sh_eth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/net/sh_eth.c~net-sh_eth-add-support-for-renesas-superh-ethernet-checkpatch-fixes drivers/net/sh_eth.c --- a/drivers/net/sh_eth.c~net-sh_eth-add-support-for-renesas-superh-ethernet-checkpatch-fixes +++ a/drivers/net/sh_eth.c @@ -29,8 +29,9 @@ #include #include #include -#include -#include +#include +#include + #include "sh_eth.h" /* @@ -614,9 +615,8 @@ static void sh_eth_timer(unsigned long d { struct net_device *ndev = (struct net_device *)data; struct sh_eth_private *mdp = netdev_priv(ndev); - int next_tick = 10 * HZ; - mod_timer( &mdp->timer, jiffies + (10 * HZ)); + mod_timer(&mdp->timer, jiffies + (10 * HZ)); } /* PHY state control function */ _