From: Andrew Morton ERROR: do not use assignment in if condition #446: FILE: drivers/oprofile/oprof.c:195: + if ((timeout_jiffies = msecs_to_jiffies(val_msec)) == MAX_JIFFY_OFFSET) total: 1 errors, 0 warnings, 491 lines checked ./patches/oprofile-multiplexing.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Andi Kleen Cc: Ingo Molnar Cc: Jason Yeh Cc: John Levon Cc: Mathieu Desnoyers Cc: Philippe Elie Cc: Thomas Gleixner Signed-off-by: Andrew Morton --- drivers/oprofile/oprof.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN drivers/oprofile/oprof.c~oprofile-multiplexing-checkpatch-fixes drivers/oprofile/oprof.c --- a/drivers/oprofile/oprof.c~oprofile-multiplexing-checkpatch-fixes +++ a/drivers/oprofile/oprof.c @@ -192,7 +192,8 @@ int oprofile_set_timeout(unsigned long v goto out; } - if ((timeout_jiffies = msecs_to_jiffies(val_msec)) == MAX_JIFFY_OFFSET) + timeout_jiffies = msecs_to_jiffies(val_msec); + if (timeout_jiffies == MAX_JIFFY_OFFSET) timeout_jiffies = msecs_to_jiffies(1); out: _