From: Andrew Morton WARNING: line over 80 characters #32: FILE: drivers/video/atmel_lcdfb.c:259: +static const struct fb_videomode *atmel_lcdfb_choose_mode(struct fb_var_screeninfo *var, WARNING: braces {} are not necessary for single statement blocks #40: FILE: drivers/video/atmel_lcdfb.c:267: + if (fbmode) { + fb_videomode_to_var(var, fbmode); + } total: 0 errors, 2 warnings, 66 lines checked ./patches/atmel_lcdfb-avoid-division-by-zero.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Antonino A. Daplas" Cc: Andrew Victor Cc: Haavard Skinnemoen Cc: Krzysztof Helt Cc: Nicolas Ferre Signed-off-by: Andrew Morton --- drivers/video/atmel_lcdfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN drivers/video/atmel_lcdfb.c~atmel_lcdfb-avoid-division-by-zero-checkpatch-fixes drivers/video/atmel_lcdfb.c --- a/drivers/video/atmel_lcdfb.c~atmel_lcdfb-avoid-division-by-zero-checkpatch-fixes +++ a/drivers/video/atmel_lcdfb.c @@ -264,9 +264,8 @@ static const struct fb_videomode *atmel_ fb_var_to_videomode(&varfbmode, var); fbmode = fb_find_nearest_mode(&varfbmode, &info->modelist); - if (fbmode) { + if (fbmode) fb_videomode_to_var(var, fbmode); - } return fbmode; } _