From: Andrew Morton WARNING: line over 80 characters #36: FILE: drivers/video/aty/radeon_base.c:2344: + err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr); WARNING: line over 80 characters #39: FILE: drivers/video/aty/radeon_base.c:2346: + err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr); ERROR: code indent should use tabs where possible #42: FILE: drivers/video/aty/radeon_base.c:2349: +^I^I __func__);$ total: 1 errors, 2 warnings, 21 lines checked ./patches/drivers-video-aty-radeon_basec-notify-user-if-sysfs_create_bin_file-failed.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Antonino A. Daplas" Cc: Benjamin Herrenschmidt Cc: Tony Breeds Cc: tony@bakeyournoodle.com (Tony Breeds) Signed-off-by: Andrew Morton --- drivers/video/aty/radeon_base.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff -puN drivers/video/aty/radeon_base.c~drivers-video-aty-radeon_basec-notify-user-if-sysfs_create_bin_file-failed-checkpatch-fixes drivers/video/aty/radeon_base.c --- a/drivers/video/aty/radeon_base.c~drivers-video-aty-radeon_basec-notify-user-if-sysfs_create_bin_file-failed-checkpatch-fixes +++ a/drivers/video/aty/radeon_base.c @@ -2341,12 +2341,14 @@ static int __devinit radeonfb_pci_regist /* Register some sysfs stuff (should be done better) */ if (rinfo->mon1_EDID) - err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr); + err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, + &edid1_attr); if (rinfo->mon2_EDID) - err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr); + err |= sysfs_create_bin_file(&rinfo->pdev->dev.kobj, + &edid2_attr); if (err) pr_warning("%s() Creating sysfs files failed, continuing\n", - __func__); + __func__); /* save current mode regs before we switch into the new one * so we can restore this upon __exit _