From: Randy Dunlap nf_conntrack_helper users rcu hlist functions so it needs to #include rculist.h. linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu' filter/nf_conntrack_helper.o] Error 1 Signed-off-by: Randy Dunlap Cc: Ingo Molnar Signed-off-by: Andrew Morton --- net/netfilter/nf_conntrack_helper.c | 1 + 1 file changed, 1 insertion(+) diff -puN net/netfilter/nf_conntrack_helper.c~netfilter-conntrack_helper-needs-to-include-rculisth net/netfilter/nf_conntrack_helper.c --- a/net/netfilter/nf_conntrack_helper.c~netfilter-conntrack_helper-needs-to-include-rculisth +++ a/net/netfilter/nf_conntrack_helper.c @@ -10,6 +10,7 @@ */ #include +#include #include #include #include _