From: Andrew Morton ERROR: do not use assignment in if condition #291: FILE: drivers/char/tpm/tpm.c:910: + if ((len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE)) <= ERROR: do not use assignment in if condition #305: FILE: drivers/char/tpm/tpm.c:925: + if ((len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE)) <= total: 2 errors, 0 warnings, 285 lines checked ./patches/tpm-increase-size-of-internal-tpm-response-buffers.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Kylene Jo Hall Cc: Marcel Selhorst Cc: Marcin Obara Signed-off-by: Andrew Morton --- drivers/char/tpm/tpm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/char/tpm/tpm.c~tpm-increase-size-of-internal-tpm-response-buffers-checkpatch-fixes drivers/char/tpm/tpm.c --- a/drivers/char/tpm/tpm.c~tpm-increase-size-of-internal-tpm-response-buffers-checkpatch-fixes +++ a/drivers/char/tpm/tpm.c @@ -907,8 +907,8 @@ ssize_t tpm_show_caps_1_2(struct device data[TPM_CAP_IDX] = TPM_CAP_PROP; data[TPM_CAP_SUBCAP_IDX] = TPM_CAP_PROP_MANUFACTURER; - if ((len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE)) <= - TPM_ERROR_SIZE) { + len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE); + if (len <= TPM_ERROR_SIZE) { dev_dbg(chip->dev, "A TPM error (%d) occurred " "attempting to determine the manufacturer\n", be32_to_cpu(*((__be32 *) (data + TPM_RET_CODE_IDX)))); @@ -922,8 +922,8 @@ ssize_t tpm_show_caps_1_2(struct device memcpy(data, cap_version, sizeof(cap_version)); data[CAP_VERSION_IDX] = CAP_VERSION_1_2; - if ((len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE)) <= - TPM_ERROR_SIZE) { + len = tpm_transmit(chip, data, TPM_INTERNAL_RESULT_SIZE); + if (len <= TPM_ERROR_SIZE) { dev_err(chip->dev, "A TPM error (%d) occurred " "attempting to determine the 1.2 version\n", be32_to_cpu(*((__be32 *) (data + TPM_RET_CODE_IDX)))); _