From: Roel Kluin <12o3l@tiscali.nl> asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Cc: Joe Perches Acked-by: Samuel Ortiz Signed-off-by: Andrew Morton --- drivers/mfd/asic3.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -puN drivers/mfd/asic3.c~asic3-platform_get_irq-may-return-signed-unnoticed drivers/mfd/asic3.c --- a/drivers/mfd/asic3.c~asic3-platform_get_irq-may-return-signed-unnoticed +++ a/drivers/mfd/asic3.c @@ -300,10 +300,13 @@ static int asic3_irq_probe(struct platfo struct asic3 *asic = platform_get_drvdata(pdev); unsigned long clksel = 0; unsigned int irq, irq_base; + int ret; + + ret = platform_get_irq(pdev, 0); + if (ret < 0) + return ret; - asic->irq_nr = platform_get_irq(pdev, 0); - if (asic->irq_nr < 0) - return asic->irq_nr; + asic->irq_nr = ret; /* turn on clock to IRQ controller */ clksel |= CLOCK_SEL_CX; _