From: Andrew Morton <akpm@linux-foundation.org>

ERROR: do not use assignment in if condition
#119: FILE: kernel/fork.c:1115:
+		if ((retval = ns_cgroup_clone(p, pid)))

total: 1 errors, 0 warnings, 94 lines checked

./patches/cgroup_clone-use-pid-of-newly-created-task-for-new-cgroup.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Dan Smith <danms@us.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Paul Menage <menage@google.com>
Cc: Serge Hallyn <serge@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/fork.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff -puN kernel/fork.c~cgroup_clone-use-pid-of-newly-created-task-for-new-cgroup-checkpatch-fixes kernel/fork.c
--- a/kernel/fork.c~cgroup_clone-use-pid-of-newly-created-task-for-new-cgroup-checkpatch-fixes
+++ a/kernel/fork.c
@@ -1112,9 +1112,11 @@ static struct task_struct *copy_process(
 	if (clone_flags & CLONE_THREAD)
 		p->tgid = current->tgid;
 
-	if (current->nsproxy != p->nsproxy)
-		if ((retval = ns_cgroup_clone(p, pid)))
+	if (current->nsproxy != p->nsproxy) {
+		retval = ns_cgroup_clone(p, pid);
+		if (retval)
 			goto bad_fork_free_pid;
+	}
 
 	p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
 	/*
_