From: Christophe Jaillet Avoid the 'memset(...,0, ...)' before calling 'init_cdrom_command' because this function already does it. Signed-off-by: Christophe Jaillet Cc: Peter Osterlund Cc: Jens Axboe Signed-off-by: Andrew Morton --- drivers/block/pktcdvd.c | 2 -- 1 file changed, 2 deletions(-) diff -puN drivers/block/pktcdvd.c~drivers-block-pktcdvdc-avoid-useless-memset drivers/block/pktcdvd.c --- a/drivers/block/pktcdvd.c~drivers-block-pktcdvdc-avoid-useless-memset +++ a/drivers/block/pktcdvd.c @@ -2082,7 +2082,6 @@ static noinline_for_stack int pkt_write_ unsigned char buf[64]; int ret; - memset(buf, 0, sizeof(buf)); init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_READ); cgc.sense = &sense; cgc.buflen = pd->mode_offset + 12; @@ -2129,7 +2128,6 @@ static noinline_for_stack int pkt_get_ma unsigned char *cap_buf; int ret, offset; - memset(buf, 0, sizeof(buf)); cap_buf = &buf[sizeof(struct mode_page_header) + pd->mode_offset]; init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_UNKNOWN); cgc.sense = &sense; _