From: Andrew Morton ERROR: do not initialise externals to 0 or NULL #42: FILE: Documentation/accounting/getdelays.c:53: +volatile sig_atomic_t reopen_log = 0; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #42: FILE: Documentation/accounting/getdelays.c:53: +volatile sig_atomic_t reopen_log = 0; WARNING: line over 80 characters #96: FILE: Documentation/accounting/getdelays.c:350: + signal(SIGUSR1, catch_usr1); /* only set when write_file is set */ WARNING: braces {} are not necessary for single statement blocks #104: FILE: Documentation/accounting/getdelays.c:469: + if (reopen_log) { + fd = reopen_logfile(fd, logfile); + } WARNING: line over 80 characters #105: FILE: Documentation/accounting/getdelays.c:470: + fd = reopen_logfile(fd, logfile); total: 1 errors, 4 warnings, 67 lines checked ./patches/getdelaysc-add-a-usr1-signal-handler.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Balbir Singh Cc: Matt Heaton Cc: Scott Wiersdorf Signed-off-by: Andrew Morton --- Documentation/accounting/getdelays.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN Documentation/accounting/getdelays.c~getdelaysc-add-a-usr1-signal-handler-checkpatch-fixes Documentation/accounting/getdelays.c --- a/Documentation/accounting/getdelays.c~getdelaysc-add-a-usr1-signal-handler-checkpatch-fixes +++ a/Documentation/accounting/getdelays.c @@ -50,7 +50,7 @@ int dbg; int print_delays; int print_io_accounting; int print_task_context_switch_counts; -volatile sig_atomic_t reopen_log = 0; +volatile sig_atomic_t reopen_log; __u64 stime, utime; #define PRINTF(fmt, arg...) { \ @@ -470,9 +470,9 @@ int main(int argc, char *argv[]) err(1,"write error\n"); } } - if (reopen_log) { - fd = reopen_logfile(fd, logfile); - } + if (reopen_log) + fd = reopen_logfile(fd, + logfile); if (!loop) goto done; break; _